Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not trigger hardcoded password on empty string, #714 #738

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

do not trigger hardcoded password on empty string, #714 #738

wants to merge 1 commit into from

Conversation

EugeneDanini
Copy link

No description provided.

@sigmavirus24
Copy link
Member

Are you not concerned about someone having a default of an empty password and not providing one? It seems as though that would be as concerning to me as a hard-coded password. In reality, it's a hard-coded empty password meaning there's no credentials there.

Even so, the tests seem to fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwb ericwb Awaiting requested review from ericwb ericwb is a code owner

@ghugo ghugo Awaiting requested review from ghugo

@lukehinds lukehinds Awaiting requested review from lukehinds lukehinds is a code owner

@sigmavirus24 sigmavirus24 Awaiting requested review from sigmavirus24 sigmavirus24 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EugeneDanini @sigmavirus24