Rename blacklist to banlist within internal modules and documentation #627
Conversation
bandit/formatters/custom.py
Outdated
| @@ -74,6 +74,7 @@ def report(manager, fileobj, sev_level, conf_level, template=None): | |||
| 'abspath': lambda issue: os.path.abspath(issue.fname), | |||
| 'relpath': lambda issue: os.path.relpath(issue.fname), | |||
| 'line': lambda issue: issue.lineno, | |||
| 'col_offset': lambda issue: issue.col_offset, | |||
There was a problem hiding this comment.
oops. that was unrelated to this PR.
|
Please fix the test, |
tonybaloney
changed the title
|
@ehooo this is now ready for a proper review. There are tests against legacy configs as well |
|
For me is fine, however, I cannot merge it. |
There was a problem hiding this comment.
This change breaks the extension model via the rename. Therefore it needs to go through a deprecation of sorts. It should still support the extension of 'blacklist' in addition to 'banlist' for a few releases before totally removing in order to give exploiters time to migrate off that extension name. And a warning message to 'blacklist' plugins would also be good.
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
|
@ericwb I added some logic to load and merge the old namespace and raise a PendingDeprecationWarning if that namespace has values https://github.com/PyCQA/bandit/pull/627/files#diff-84fa5c2b26f1476808885d6e44c73f40R74-R85 |
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
Co-authored-by: Eric Brown <ericwb@users.noreply.github.com>
|
@ericwb the requested changes were made |
|
Hi. I unknowingly opened a separate issue and pushed a change under #647 |
|
@jwstein3400 I don't mind what its called, as long as its changed from the current terminology. Happy to close this one or you can merge any changes from here into your branch. I'm just waiting for one of the maintainers to review and merge. |
There was a problem hiding this comment.
banlist is not a very correct term. The things that are in blacklists are not technically banned, but just warned about by bandit.
IMHO it is the campaign of replacement of neutral terms with the words white and black racist (we in Russia have an idiom that can literaly be translated into English as "the thief has his hat burning", usually attributed to a folk story about an improvised guilty-knowledge test to detect thieves in a crowd at market and meaning the situation when someone socially inacceptable (i.e. the thief from the story) trying to play innocent (in the story it'd be to just ignore the scream, rather that touching the hat) but fails because he is a bad in acting), not the practice of using the words being replaced.
What about using cc: @KOLANICH |
|
As I have said, I think that the whole this campaign of renaming neutral things into "more neutral" is lot of useless fuzz out of nothing and is not so smart. I.e. they have renamed |
|
Closing PR. Have had no reply from maintainers of the project and the PR is now wildly out of date/conflicting with main branch |
This proposed change replaces the use of the term "blacklist" with a replacement, "banlist".
The change is mostly an internal refactoring task.
Some notes:
Could the core development team please comment on this proposal?
I would gladly make amendments, continue and extend the testing to have this change merged as I believe it would benefit the Python community not to use the term blacklist in such an important project as bandit.
@ericwb @lukehinds @ehooo @viraptor