New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot seek stdin on pipe #496
Merged
Merged
Changes from 39 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
272fd74
add namespaces for parent attributes
tylerwince 7a5e827
pylint formatting changes
tylerwince 583149a
added _Seeker for running seek on sys.stdin
tylerwince cf4f11a
Merge branch 'master' into 495-cannot-seek-stdin-on-pipe
tylerwince acd80a7
Update node_visitor.py
tylerwince edcecbe
Update general_hardcoded_password.py
tylerwince ca5cfe3
Update general_hardcoded_password.py
tylerwince 6a33c6e
pep8 fixes
tylerwince 91543c2
added list handling for hard fname swaps
cat-code 969e816
updated manager
tylerwince 6535101
maintaining list order
cat-code 10c6378
Merge pull request #1 from JuanHuaXu/495-cannot-seek-stdin-on-pipe
tylerwince 9f99d63
updated pep8 errors
tylerwince c9bb2b5
Merge branch 'master' into 495-cannot-seek-stdin-on-pipe
tylerwince 8305291
Merge branch 'master' into 495-cannot-seek-stdin-on-pipe
tylerwince 132e1c2
Merge branch 'master' into 495-cannot-seek-stdin-on-pipe
tylerwince c88dcac
Merge branch 'master' into 495-cannot-seek-stdin-on-pipe
ericwb ce523ba
Merge branch 'master' into 495-cannot-seek-stdin-on-pipe
tylerwince 7b62387
Merge branch 'master' into 495-cannot-seek-stdin-on-pipe
ericwb c4dda4d
Merge branch 'master' into 495-cannot-seek-stdin-on-pipe
ericwb 235acee
Merge branch 'master' into 495-cannot-seek-stdin-on-pipe
ericwb 8038c11
Merge branch 'main' into 495-cannot-seek-stdin-on-pipe
ericwb fe741b4
Update manager.py
ericwb b035898
Update manager.py
ericwb f0e8316
Update manager.py
ericwb f0106e4
Update issue.py
ericwb e27cb8a
Update node_visitor.py
ericwb 410a7cf
Update manager.py
ericwb 0b43d58
Update issue.py
ericwb 3f0139e
Update context.py
ericwb 128fb4e
Update issue.py
ericwb 217fe52
Update manager.py
ericwb 1a9b389
Update node_visitor.py
ericwb 4ab2d4a
Update tester.py
ericwb c42e501
Update issue.py
ericwb e583627
Update manager.py
ericwb 86ffba3
Update context.py
ericwb a5e44ba
Update node_visitor.py
ericwb 2e9b2d4
Update manager.py
ericwb 6562a4d
Merge branch 'main' into 495-cannot-seek-stdin-on-pipe
tylerwince File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump for visibility, please see the number of issues that are being linked to this PR. This change to
BanditNodeVisitor
, which introduces new positional argumentfdata
in the middle of the signature, causes a backwards-incompatible break withflake8-bandit
, which uses this object.Ideally, this new argument should have been added to the end of the signature as an optional kwarg. Barring that, as small as this change is, this is now more than a patch update: I think this should have been released as
1.8.0
instead of1.7.3
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bandit doesn't guarantee stability of its internals. Tools reaching in and trying to use them will break much like tools that reach directly into Flake8 for things they shouldn't