-
-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more_info URL to screen formatter #360
Conversation
Patch set adds more_info URL to the screen output. Partially-Closes: PyCQA#323 Signed-off-by: Tin Lam <tin@irrational.io>
Signed-off-by: Tin Lam <tin@irrational.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch with the example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit
@@ -18,17 +18,18 @@ | |||
Screen formatter | |||
================ | |||
This formatter outputs the issues as color coded text. | |||
This formatter outputs the issues as color coded text to screen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to the screen
:Example: | ||
.. code-block:: none | ||
>> Issue: [B301:blacklist_calls] Use of unsafe yaml load. Allows | ||
>> Issue: [B506: yaml_load] Use of unsafe yaml load. Allows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
Patch set adds more_info URL to the screen formatter.
Partially-Closes: #323
Signed-off-by: Tin Lam tin@irrational.io