Add action to upload the wheel and tar-zipped distributions #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already publish to PyPI our packages. It is also useful to publish our binaries as artifacts here on GitHub. This action will build and publish release files as artifacts in the current release. It runs whenever a new release is published. This change also adds attestation of the artifacts so that users can verify the binary is the authentic one produced by our build. More info on attestation here: https://github.blog/2024-05-02-introducing-artifact-attestations-now-in-public-beta/ Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com>
|
There's almost no value in doing this. Twine and PyPI are actively implementing support for attestations |
|
I know PyPI has been working on this for a while. Is it available yet? But yes, I understand how this can be redundant to have two destinations for artifacts and two ecosystems to attest them. It definitely feels like GitHub is attempting to a one-stop shop for all things code. I thought it was nice that you can attest the binaries with GitHub's CLI. Does Pip have plans for the same? In any case, I can close this as I don't want to create confusion on where to obtain binaries and how to attest them. |
|
Thinking about this more, totally agree. It's a bad idea to have two source repositories to fetch packages, each with it's own attestation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already publish to PyPI our packages. It is also useful to publish our binaries as artifacts here on GitHub. This action will build and publish release files as artifacts in the current release.
It runs whenever a new release is published.
This change also adds attestation of the artifacts so that users can verify the binary is the authentic one produced by our build.
More info on attestation here:
https://github.blog/2024-05-02-introducing-artifact-attestations-now-in-public-beta/