New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pytorch Load / Save Plugin #1114
Open
lukehinds
wants to merge
8
commits into
PyCQA:main
Choose a base branch
from
lukehinds:pytorch-checks
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin checks for the use of `torch.load` and `torch.save`. Using `torch.load` with untrusted data can lead to arbitrary code execution, and improper use of `torch.save` might expose sensitive data or lead to data corruption. Signed-off-by: Luke Hinds <luke@stacklok.com>
Bit of cleaning up to do, will get onto next week |
Closing and reopening to trigger precommit ci to auto fix this for you |
for more information, see https://pre-commit.ci
sigmavirus24
reviewed
Mar 3, 2024
ericwb
reviewed
Mar 3, 2024
Signed-off-by: Luke Hinds <luke@stacklok.com>
Signed-off-by: Luke Hinds <luke@stacklok.com>
Signed-off-by: Luke Hinds <luke@stacklok.com>
@sigmavirus24 / @ericwb I think I have reviewed most of the points now, fancy taking a second sweep? |
ericwb
reviewed
Mar 13, 2024
Signed-off-by: Luke Hinds <luke@stacklok.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first plugin 馃帀
This plugin checks for the use of
torch.load
andtorch.save
.Using
torch.load
with untrusted data can lead to arbitrary code execution,and improper use of
torch.save
might expose sensitive data or lead to datacorruption.