Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more_info URL to screen formatter #360

Merged
merged 2 commits into from Aug 9, 2018
Merged

Conversation

stannum-l
Copy link
Contributor

Patch set adds more_info URL to the screen formatter.

Partially-Closes: #323

Signed-off-by: Tin Lam tin@irrational.io

Patch set adds more_info URL to the screen output.

Partially-Closes: PyCQA#323

Signed-off-by: Tin Lam <tin@irrational.io>
Signed-off-by: Tin Lam <tin@irrational.io>
@ghugo ghugo requested review from ghugo and ericwb August 9, 2018 16:20
Copy link
Contributor

@ghugo ghugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch with the example

Copy link
Member

@ericwb ericwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit

@@ -18,17 +18,18 @@
Screen formatter
================

This formatter outputs the issues as color coded text.
This formatter outputs the issues as color coded text to screen.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to the screen


:Example:

.. code-block:: none

>> Issue: [B301:blacklist_calls] Use of unsafe yaml load. Allows
>> Issue: [B506: yaml_load] Use of unsafe yaml load. Allows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@ericwb ericwb merged commit a39b408 into PyCQA:master Aug 9, 2018
@stannum-l stannum-l deleted the screen-links branch August 10, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants