Fix syntax for overloaded operator methods #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `op_False`, `op_True` should get mapped to `false`, `true`. * Overloaded operator methods should include the `operator` keyword before the operator symbol. Otherwise we end up with output that's syntactically invalid C#.
danielmarbach
approved these changes
Jun 18, 2020
|
Thanks for finding and fixing it! |
|
Should go out in a few mins as 10.1.2 |
|
I never cease to be surprised at how we could have missed so many (obvious) details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #49. Fixes #192.