Support for more method modifiers #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
force-pushed
the
method-virtual
branch
from
e3867e0
to
7f76c50
Compare
sungam3r
reviewed
Nov 19, 2019
jnm2
reviewed
Nov 19, 2019
jnm2
approved these changes
Nov 19, 2019
Comment on lines
+16
to
+19
| if (methodDefinition.DeclaringType.IsInterface) | ||
| { | ||
| return name; | ||
| } |
There was a problem hiding this comment.
ℹ This is going to have to change in the future to support the many modifiers now allowed on interface members in C#.
https://docs.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-8#default-interface-methods
There was a problem hiding this comment.
Don't get me started... 😂
Yeah but we can focus on that in another major release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for more method scenarios for #112