Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix member ordering #138

Merged
merged 5 commits into from Nov 15, 2019
Merged

Fix member ordering #138

merged 5 commits into from Nov 15, 2019

Conversation

adamralph
Copy link
Contributor

No description provided.

@sungam3r
Copy link
Member

Interesting attention to detail 👍

@adamralph
Copy link
Contributor Author

adamralph commented Nov 15, 2019

@danielmarbach I realised that having static and instance members jumbled together isn't great either, so I pushed fixup commits to alter the tests and implementation to ensure statics come after instance members. I guess my (slight) preference may be to have statics before instance members, but we'd have to alter some more existing tests before making that change.

@danielmarbach
Copy link
Member

Honestly I prefer consistency over any member ordering preferences. As long as we have a stable way to sort things we are good and I would try to avoid to go to far into any directions of "I like it this way" because then someone else will come and say "but this other way is much better".

@danielmarbach danielmarbach merged commit e11d012 into PublicApiGenerator:master Nov 15, 2019
@adamralph adamralph deleted the fix-member-ordering branch November 16, 2019 08:27
@danielmarbach danielmarbach added this to the 10.0.0 milestone Nov 27, 2019
@danielmarbach danielmarbach mentioned this pull request Nov 27, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants