Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event modifier support #130

Merged
merged 9 commits into from Nov 8, 2019
Merged

Event modifier support #130

merged 9 commits into from Nov 8, 2019

Conversation

danielmarbach
Copy link
Member

@danielmarbach danielmarbach commented Nov 8, 2019

Fixes #113

@danielmarbach
Copy link
Member Author

@jnm2 Not exactly a beauty but it works and fixes the

public event 
```

problem on interfaces as well 

@danielmarbach
Copy link
Member Author

Green now

@sungam3r
Copy link
Member

sungam3r commented Nov 8, 2019

Replacement magic back and forth :)

@danielmarbach
Copy link
Member Author

OMG. I feel dirty now, really dirty

@danielmarbach danielmarbach merged commit 87ae6ee into master Nov 8, 2019
@danielmarbach danielmarbach deleted the sealed_override branch November 8, 2019 21:22
@jnm2
Copy link
Contributor

jnm2 commented Nov 8, 2019

@danielmarbach Sorry, I forgot about abstract override.

@jnm2
Copy link
Contributor

jnm2 commented Nov 8, 2019

@danielmarbach Sorry, I forgot about abstract override.

Wouldn't it be better to have a separate check for each keyword in order and append them as you go, so that you don't have to special-case every possible combination?

@danielmarbach
Copy link
Member Author

Maybe but I'm done here #133

@danielmarbach danielmarbach mentioned this pull request Nov 27, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static/new/virtual/abstract/sealed/override keywords are missing for events
3 participants