Add syntax for volatile fields #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all "small"/"helper" methods from ApiGenerator to extensions to keep it clean fixes #116
|
Can you for the next time have one commit that add the volatile and another commit that does the cleanup. That simplifies reviewing a lot. I basically had to search through the file changes to be able to see what is the actual change and what is cleanup |
|
Sure. Sorry, when I remembered that it was necessary to make the first separate commit, it was already too late. Sometimes you forget yourself in the stream of thoughts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all "small"/"helper" methods from ApiGenerator to extensions to keep it clean
fixes #116