Merge pull request #191 from stakx/serializableattribute

PublicApiGenerator · Jun 17, 2020 · 1e377fa · 1e377fa
2 parents a2a2490 + c802f4e
commit 1e377fa
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 2 deletions.
diff --git a/src/PublicApiGenerator/ApiGenerator.cs b/src/PublicApiGenerator/ApiGenerator.cs
@@ -441,6 +441,23 @@ bool IsSpecialConstraint(GenericParameterConstraint constraint)
                 var attribute = GenerateCodeAttributeDeclaration(codeTypeModifier, customAttribute);
                 attributes.Add(attribute);
             }
+
+            // so this is not very cool but at least all the attribute creation is in the same place
+            PopulateAttributesThatDontAppearInCustomAttributes(type, attributes);
+        }
+
+        static void PopulateAttributesThatDontAppearInCustomAttributes(ICustomAttributeProvider type,
+            CodeAttributeDeclarationCollection attributes)
+        {
+            if (type is TypeDefinition typeDefinition)
+            {
+                if (typeDefinition.Attributes.HasFlag(Mono.Cecil.TypeAttributes.Serializable))
+                {
+                    var attribute = new CodeAttributeDeclaration("System.SerializableAttribute");
+                    attribute.Name = AttributeNameBuilder.Get(attribute.Name);
+                    attributes.Add(attribute);
+                }
+            }
         }
 
         static CodeAttributeDeclaration GenerateCodeAttributeDeclaration(Func<CodeTypeReference, CodeTypeReference> codeTypeModifier, CustomAttribute customAttribute)
@@ -667,7 +684,7 @@ static object FormatParameterConstant(ParameterDefinition parameter)
                 // this seems right for default
                 return "default";
             }
-            
+
             return parameter.ParameterType.IsValueType ? "default" : "null";
         }
 

diff --git a/src/PublicApiGeneratorTests/Class_attributes.cs b/src/PublicApiGeneratorTests/Class_attributes.cs
@@ -1,5 +1,5 @@
-using PublicApiGenerator;
 using PublicApiGeneratorTests.Examples;
+using System;
 using Xunit;
 
 namespace PublicApiGeneratorTests
@@ -294,6 +294,20 @@ public class ClassWithMultipleAttributes
     }
 }", options);
         }
+
+        [Fact]
+        public void Should_include_Serializable_attribute()
+        {
+            AssertPublicApi<ClassWithSerializableAttribute>(
+                @"namespace PublicApiGeneratorTests.Examples
+{
+    [System.Serializable]
+    public class ClassWithSerializableAttribute
+    {
+        public ClassWithSerializableAttribute() { }
+    }
+}");
+        }
     }
 
     // ReSharper disable UnusedMember.Global
@@ -403,6 +417,11 @@ public class ClassWithAttributeWithMultipleUsagesSupport
         public class ClassWithInternalAttribute
         {
         }
+
+        [Serializable]
+        public class ClassWithSerializableAttribute
+        {
+        }
     }
     // ReSharper restore ClassNeverInstantiated.Global
     // ReSharper restore UnusedMember.Global