DRAFT: Fix dst-transition-leap spreading to subsequent events #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schreven
force-pushed
the
fix/recurrence-on-dst
branch
2 times, most recently
from
6dbb10b
to
882a18e
Compare
schreven
changed the title
schreven
force-pushed
the
fix/recurrence-on-dst
branch
from
882a18e
to
90e3154
Compare
schreven
force-pushed
the
fix/recurrence-on-dst
branch
2 times, most recently
from
7ff600f
to
d9f246d
Compare
…e timezone guesser test
schreven
force-pushed
the
fix/recurrence-on-dst
branch
from
d9f246d
to
19d0ed4
Compare
Comment on lines
+1292
to
+1310
| private function revertPastOffset(\DateTimeInterface $dateTime): \DateTimeInterface | ||
| { | ||
| if (!is_numeric($this->counter)) { | ||
| return $dateTime; | ||
| } | ||
|
|
||
| $previousIterationLeapOffset = $this->leapOffset[(int) $this->counter - 1] ?? null; | ||
|
|
||
| if (!is_int($previousIterationLeapOffset)) { | ||
| return $dateTime; | ||
| } | ||
|
|
||
| $modifiedDateTime = $dateTime->modify("- $previousIterationLeapOffset seconds"); | ||
|
|
||
| unset($this->leapOffset[$this->counter - 1]); | ||
|
|
||
| return $modifiedDateTime; | ||
| } | ||
|
|
There was a problem hiding this comment.
if you are anyway always resetting the previous offset, why keep a list of them? 🤔
There was a problem hiding this comment.
Before my last commit, it was possible to call this method and "detectAndSaveDstOffset" multiple times per iteration. It's probably not needed anymore indeed
|
I'm not satisfied with the approach altogether. It's error-prone and not really future proof. I'll close this and submit a bug report upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.