Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump typescript from 4.1.2 to 4.1.3 #67

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 14, 2020

Bumps typescript from 4.1.2 to 4.1.3.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added automerge Automatically merge the PR when checks are passing and approval has been obtained dependencies Updates to dependencies labels Dec 14, 2020
@dependabot dependabot bot requested a review from rintaun December 14, 2020 18:11
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-4.1.3 branch from 3ce7592 to 394f806 Compare December 14, 2020 19:11
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](https://github.com/Microsoft/TypeScript/commits)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-4.1.3 branch from 394f806 to ba0527b Compare December 14, 2020 19:16
@rintaun
Copy link
Member

rintaun commented Dec 14, 2020

Array.isArray behavior was reverted in 4.1.3 due to breaking changes it introduced. Unfortunately that makes 4.1.3 a breaking change for us. Hopefully it will be working as expected again in a future update. See microsoft/TypeScript#41808

Summary of issue (simplified):

Before (4.1.2):

private eachResult<TData>(results: TData | ReadonlyArray<TData>): void {
  if (!Array.isArray(results)) { // results: TData
    results = [results]
  }
}

After (4.1.3):

private eachResult<TData>(results: TData | ReadonlyArray<TData>): void {
  if (!Array.isArray(results)) { // results: TData | readonly TData[]
    results = [results] // Type '(TData | readonly TData[])[]' is not assignable to type 'TData | readonly TData[]'.
  }
}

@rintaun rintaun closed this Dec 14, 2020
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 14, 2020

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@rintaun rintaun deleted the dependabot/npm_and_yarn/typescript-4.1.3 branch December 14, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge the PR when checks are passing and approval has been obtained dependencies Updates to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant