Replace react-hot-loader with react-refresh #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3213 +/- ##
=======================================
Coverage 90.55% 90.55%
=======================================
Files 187 187
Lines 3155 3155
=======================================
Hits 2857 2857
Misses 298 298
Continue to review full report at Codecov.
|
mejackreed
force-pushed
the
replace-hot-loader
branch
from
e557980
to
693b13f
Compare
mejackreed
commented
Jul 13, 2020
mejackreed
force-pushed
the
replace-hot-loader
branch
from
693b13f
to
57c0c49
Compare
mejackreed
force-pushed
the
replace-hot-loader
branch
from
57c0c49
to
cc262bf
Compare
mejackreed
force-pushed
the
replace-hot-loader
branch
from
cc262bf
to
4140b6c
Compare
cbeer
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per facebook/react#16604 (comment) and gaearon/react-hot-loader#1453 it seems like react-hot-loader is deprecated.
This replaces react-hot-loader w/ react-refresh and https://github.com/pmmmwh/react-refresh-webpack-plugin. I'm thinking that this implementation will be preferred as it does not keep the lingering react-hot-loader around in distributed package.
Related to #3198
This change has also been tested on IE11 for the production umd build.