Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][#242] Add PR Labeler and its configuration and update CONTRIBUTION.md #243

Closed
wants to merge 1 commit into from
Closed

[feature][#242] Add PR Labeler and its configuration and update CONTRIBUTION.md #243

wants to merge 1 commit into from

Conversation

IsaacYangSLA
Copy link
Contributor

@IsaacYangSLA IsaacYangSLA commented Apr 1, 2020

Fixes #242

Description

Improvement on release drafter to automatically categorize PR in release note.

Status

WIP

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated
  • Improvement on configuration on CI

@IsaacYangSLA
Copy link
Contributor Author

This PR labeller action has a big drawback. It could not work on PR from fork. See two issues from two different github actions, both of which automatically label PR based on patterns of branch names.
actions/labeler#12 and TimonVS/pr-labeler-action#25

@IsaacYangSLA
Copy link
Contributor Author

Because PR Labeler could not handle PR from fork, the action failed. Will close this one as the failed action is confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic labeling on PR so changes in release notes are categorized
1 participant