New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove $SRC_DIR so cached builds have files from latest commit #158

Open

sk33lz wants to merge 1 commit into master from fix/sk33lz/cached-build-clean-src

Contributor

sk33lz commented May 1, 2019

No description provided.


          Remove $SRC_DIR so cached builds have files from latest commit

9652e11

sk33lz added the Needs Testing label

sk33lz self-assigned this

Auspicus commented May 3, 2019

@sk33lz Submitted #159.

Did this across all the source code downloader tasks. We discussed moving it to a higher level abstraction like "SourceCodeDownloader".

I figured because there's already duplication (these lines appear across all downloaders: https://github.com/ProboCI/probo/blob/master/lib/plugins/TaskRunner/BitbucketDownloader.js#L91-L92) that the work to move the downloader setup to an abstraction should probably be left for another PR.

ElusiveMind assigned ElusiveMind and unassigned sk33lz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment