bedrock/1.19.30 initial commit #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extremeheat
reviewed
Sep 12, 2022
data/bedrock/latest/proto.yml
Outdated
| # Repetitions represents the amount of times the test will be run. | ||
| repetitions: varint | ||
| # Rotation represents the rotation of the test. It is one of the constants above. | ||
| rotation: u8 |
There was a problem hiding this comment.
we can add the constants in https://github.com/Sandertv/gophertunnel/pull/146/files#diff-7da5dae79269c9351484664f4b134a04deafc18b605327b4ee649659907d078cR5 for clarity that this is not an analog field
There was a problem hiding this comment.
Done and done. Good catch!
Re game_test_request.rotation:
- okay... i guess that works. I suppose they would have to step up to 16-bit if they wanted 360 degrees.
- Kept them as indexed integers. Would strings be better? or perhaps qualified strings (
"rotation0")?: - 0... and 360?
There was a problem hiding this comment.
Yeah, using numbers in the enum isn't good because that can create data type collisions. As users can specify the string enum representation or specify a numeric value for these fields, this means ambiguity when serializing in protodef. I've corrected them to be strings.
|
Thanks for the work on this! |
rom1504
pushed a commit
to frej4189/minecraft-data
that referenced
this pull request
Dec 19, 2022
* bedrock/1.19.30 initial commit * Fix broken link (oops) * Fix datapaths (bad rebase artifact) * Add missing yml files * Add missing enumerations * Update protocol.json * Update proto.yml Avoid field data type clashing * protocol updates for v554 * correction to RecipeIngredient's int_id_meta * rebuild JSONs Co-authored-by: extremeheat <extreme@protonmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs work on bedrock-protocol end.
Used Sandertv/gophertunnel#146 as a guide, but skipped add_player and update_abilities packet changes as they seem to be just subtyping and nothing functional.