Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Enum support from QueryStrings #1953

Merged
merged 3 commits into from Nov 21, 2019
Merged

Adding Enum support from QueryStrings #1953

merged 3 commits into from Nov 21, 2019

Commits on Nov 20, 2019

  1. included tests for each function changed + considered enum name or va… 

    …lue during conversion
    @candidodmv @dansiegel
    candidodmv authored and dansiegel committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    cbacc3f View commit details
    Browse the repository at this point in the history

  2. included tests for each function changed + considered enum name or va… 

    …lue during conversion

Allow bind Enum values in IAutoInitialize ViewModels

Currently if anyone try pass through a enum value as raw type(value or name) within INavigationParameters get an error of conversion, to solve this problem was included the conditions above.

Allow bind Enum values in IAutoInitialize ViewModels

Currently if anyone try pass through a enum value as raw type(value or name) within INavigationParameters get an error of conversion, to solve this problem was included the conditions above.

Update ParametersExtensions.cs

force to use only enum name

I'm considering to use only the enum name because if the value is being considered during the conversion can cause side effect because the value as number can be refered to a lot of things in navigation parameters not the enum type searched.
    @candidodmv @dansiegel
    candidodmv authored and dansiegel committed Nov 20, 2019
    Configuration menu
    Copy the full SHA
    26e090c View commit details
    Browse the repository at this point in the history

  3. Fixing Enum Support to allow setting from numeric or string

    @dansiegel
    dansiegel committed Nov 20, 2019
    1 Configuration menu
    Copy the full SHA
    053eb30 View commit details
    Browse the repository at this point in the history