Adding Enum support from QueryStrings #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lue during conversion
…lue during conversion Allow bind Enum values in IAutoInitialize ViewModels Currently if anyone try pass through a enum value as raw type(value or name) within INavigationParameters get an error of conversion, to solve this problem was included the conditions above. Allow bind Enum values in IAutoInitialize ViewModels Currently if anyone try pass through a enum value as raw type(value or name) within INavigationParameters get an error of conversion, to solve this problem was included the conditions above. Update ParametersExtensions.cs force to use only enum name I'm considering to use only the enum name because if the value is being considered during the conversion can cause side effect because the value as number can be refered to a lot of things in navigation parameters not the enum type searched.
3 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a rebased and fixed version of PR #1916. This adds tests both for ParametersBase and IAutoInitialize specifically. Be sure to note some of the behavior changes.
Bugs Fixed
API Changes
none
Behavioral Changes
Updates GetValue / TryGetValue from the ParametersBase. All Get Value methods now use a single internal TryGet method so that the conversion from the KeyValuePair's Value (which may be a string if it was from the QueryString) to whatever the requested type is will use the same exact logic. We now will be intentional in throwing an InvalidArgumentException when calling GetValue in the event that we could not convert the value to the requested type.
This also fixes a very incorrect assumption that at the event you got to the end of our type conversion logic that the value must be convertible. This now ensures that if we get to the point that we want to try
Convert.ChangeTypethat we first validate that it implementsIConvertiblePR Checklist