[ Product Filter ] - FRONT #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kktos
requested changes
Apr 23, 2024
_dev/apps/ui/src/enums/product-feed/product-filter-condition.ts
Outdated
Show resolved
Hide resolved
_dev/apps/ui/src/enums/product-feed/product-filter-condition.ts
Outdated
Show resolved
Hide resolved
_dev/apps/ui/src/components/product-feed/settings/product-selection/type.ts
Outdated
Show resolved
Hide resolved
_dev/apps/ui/src/components/product-feed/settings/product-selection/type.ts
Outdated
Show resolved
Hide resolved
_dev/apps/ui/src/components/product-feed/settings/product-selection/product-selection.vue
Show resolved
Hide resolved
_dev/apps/ui/src/components/product-feed/settings/product-selection/product-selection.vue
Outdated
Show resolved
Hide resolved
_dev/apps/ui/src/components/product-feed/settings/product-selection/line-filter.vue
Show resolved
Hide resolved
_dev/apps/ui/src/components/product-feed/settings/product-selection/line-filter.vue
Outdated
Show resolved
Hide resolved
_dev/apps/ui/src/components/product-feed/settings/product-selection/line-filter.vue
Outdated
Show resolved
Hide resolved
| class="field-number" | ||
| :class="{'error-field': filters.errors?.value}" | ||
| :append="attributeSelected.value === 'price' && currencySymbol !== 'en-gb' ? currencySymbol : undefined" | ||
| :prepend="attributeSelected.value === 'price' && currencySymbol === 'en-gb' ? currencySymbol : undefined" |
There was a problem hiding this comment.
a function would be better here
kktos
requested changes
Apr 24, 2024
_dev/apps/ui/src/components/product-feed/settings/product-selection/type.ts
Outdated
Show resolved
Hide resolved
kktos
requested changes
Apr 24, 2024
_dev/apps/ui/src/components/product-feed/settings/product-selection/line-filter.vue
Show resolved
Hide resolved
_dev/apps/ui/src/components/product-feed/settings/product-selection/type.ts
Outdated
Show resolved
Hide resolved
kktos
requested changes
Apr 24, 2024
_dev/apps/ui/src/components/product-feed/settings/product-selection/line-filter.vue
Outdated
Show resolved
Hide resolved
kktos
requested changes
Apr 26, 2024
_dev/apps/ui/src/components/product-feed/settings/product-selection/product-selection.vue
Outdated
Show resolved
Hide resolved
kktos
requested changes
Apr 26, 2024
_dev/apps/ui/src/components/product-feed/settings/product-selection/type.ts
Show resolved
Hide resolved
ga-devfront
force-pushed
the
product-filter-front
branch
from
b470127
to
3c1fef0
Compare
ga-devfront
added
waiting for dev
kseghair
approved these changes
May 15, 2024
ga-devfront
merged commit a97c20d
into
PrestaShopCorp:feature/product-filter
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.