Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on Hummingbird situation #1287

Merged
merged 3 commits into from
May 8, 2024

Conversation

kpodemski
Copy link
Contributor

No description provided.

@kpodemski kpodemski requested a review from matks April 12, 2024 09:00
Copy link
Contributor

@PrestaEdit PrestaEdit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it's an edit, I will appreciate that we leave the first content and just add the newest notice, there.

@matthieu-rolland
Copy link
Contributor

As it's an edit, I will appreciate that we leave the first content and just add the newest notice, there.

I think While we would love to see Hummingbird in PrestaShop 9 reminds the reader that's that indeed what we want, or you want to make it more obvious that there is potentially a "change of plan" ?

@PrestaEdit
Copy link
Contributor

More obious, and I'd like to get the updated infos in addition of previous read, as an update and not a replacement, when I read a blog post from past, on my side.

@kpodemski
Copy link
Contributor Author

@PrestaEdit I edited the text, I hope we met halfway to clarify the message. The main point is to state the current situation.

@kpodemski
Copy link
Contributor Author

cc @matks @MatShir

@PrestaEdit
Copy link
Contributor

@PrestaEdit I edited the text, I hope we met halfway to clarify the message. The main point is to state the current situation.

Thanks @kpodemski ! I appreciate the change, and approve it ! :)

Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, let's publish tomorrow. Also added a little fix

content/news/posts/2022/new-theme-announce.md Outdated Show resolved Hide resolved
Co-authored-by: Mathieu Ferment <mathieu.ferment@prestashop.com>
@kpodemski kpodemski merged commit 41ae18b into PrestaShop:master May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants