Improve UI tests for API modules #36187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolelievre
changed the title
… toggle that needs to wait a bit longer and force using specific modules
jolelievre
force-pushed
the
api-modules-tests
branch
from
ddcb8da
to
8771197
Compare
Progi1984
reviewed
May 17, 2024
Comment on lines
+150
to
+151
| let isModuleVisible = await moduleManager.searchModule(page, {tag: 'statscarrier'} as FakerModule); | ||
| expect(isModuleVisible).to.be.equal(true); |
There was a problem hiding this comment.
Suggested change
| let isModuleVisible = await moduleManager.searchModule(page, {tag: 'statscarrier'} as FakerModule); | |
| expect(isModuleVisible).to.be.equal(true); | |
| const isModule1Visible = await moduleManager.searchModule(page, {tag: 'statscarrier'} as FakerModule); | |
| expect(isModule1Visible).to.be.equal(true); |
Progi1984
reviewed
May 17, 2024
Comment on lines
+154
to
+155
| isModuleVisible = await moduleManager.searchModule(page, {tag: 'pagesnotfound'} as FakerModule); | ||
| expect(isModuleVisible).to.be.equal(true); |
There was a problem hiding this comment.
Suggested change
| isModuleVisible = await moduleManager.searchModule(page, {tag: 'pagesnotfound'} as FakerModule); | |
| expect(isModuleVisible).to.be.equal(true); | |
| const isModule2Visible = await moduleManager.searchModule(page, {tag: 'pagesnotfound'} as FakerModule); | |
| expect(isModule2Visible).to.be.equal(true); |
Progi1984
reviewed
May 17, 2024
| await testContext.addContextItem(this, 'testIdentifier', `checkModules${index}`, baseContext); | ||
|
|
||
| await dashboardPage.goToSubMenu(page, dashboardPage.modulesParentLink, dashboardPage.modulesParentLink); | ||
| // Extra wait for this one because the cache has been cleared by the previous API call | ||
| await dashboardPage.goToSubMenu(page, dashboardPage.modulesParentLink, dashboardPage.modulesParentLink, 60000); |
There was a problem hiding this comment.
Always need to do that ?
There was a problem hiding this comment.
Since the cache is cleared after the API call I think it's safer to wait a bit longer, the first page is really long to load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full campaign: https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/9130335672