Refacto login forms and add Employee CQRS commands #36162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jolelievre
commented
May 15, 2024
•
jolelievre
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | Refacto login forms |
| Type? | refacto |
| Category? | BO |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | UI tests and ci green |
| UI Tests | https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/9193722916 |
| Fixed issue or discussion? | Fixes #36159 |
| Related PRs | ~ |
| Sponsor company | ~ |
jolelievre
changed the title
jolelievre
force-pushed
the
refacto-login-forms
branch
5 times, most recently
from
f9386e9
to
e5ae01d
Compare
jolelievre
force-pushed
the
refacto-login-forms
branch
2 times, most recently
from
63cdf77
to
f6bb8a7
Compare
tleon
previously approved these changes
May 21, 2024
boherm
previously approved these changes
May 21, 2024
ps-jarvis
added
the
Waiting for QA
jolelievre
force-pushed
the
refacto-login-forms
branch
from
f6bb8a7
to
6002d87
Compare
jolelievre
removed
the
Waiting for QA
…dType, improve validation feedback on reset form
jolelievre
force-pushed
the
refacto-login-forms
branch
from
6002d87
to
7d3a131
Compare
boherm
approved these changes
May 22, 2024
tleon
approved these changes
May 24, 2024
ps-jarvis
added
the
Waiting for QA
jolelievre
removed
the
Waiting for QA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.