Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "brand" as column heading #36118

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

fulldecent
Copy link
Contributor

@fulldecent fulldecent commented May 8, 2024

Questions Answers
Branch? develop
Description? This fixes the example import file products_example.csv to use the format expected during import process. It replaces "Manufacturer" by "Brand" in the CSV example file. Consequently in the import process, the data column and the file columns are matched. See the "How to test" to better understand.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? See below
UI Tests
Fixed issue or discussion? Progress on #36117, related to https://github.com/PrestaShop/PrestaShop/discussions/ {discussion number here} but does not completely fix them
Related PRs None

How to test?

In order to understand the problem

  1. Go to backoffice import page, download the "Sample product file"
  2. This is a CSV file named products_import.csv. Keep it.
  3. Now you are in backoffice import page. Fill the form:
  • * What do you want to import? input "Products"
  • Select a file to import input the products_import.csv file you downloaded
  1. Click on "Next step"
  2. On the next screen, use the arrows to browse the file and see the column "Manufacturer" in the file. It is used to match the "Brand" column in the data matching

Capture d’écran 2024-06-07 à 15 54 51

In order to verify the fix

  1. Use the code from this PR. Go to backoffice import page, download the "Sample product file"
  2. This is a CSV file named products_import.csv. Keep it.
  3. Now you are in backoffice import page. Fill the form:
  • * What do you want to import? input "Products"
  • Select a file to import input the products_import.csv file you downloaded
  1. Click on "Next step"
  2. On the next screen, use the arrows to browse the file and see the column "Brand" in the file. It is used to match the "Brand" column in the data matching. The two match!

Capture d’écran 2024-06-07 à 15 55 14

@fulldecent fulldecent requested a review from a team as a code owner May 8, 2024 14:50
@prestonBot
Copy link
Collaborator

prestonBot commented May 8, 2024

Hi, thanks for this contribution!

Please consider opening an issue before submitting a Pull Request:

  • If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
  • It can help trigger a discussion about the best implementation path before a single line of code is written.
  • It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added develop Branch Bug fix Type: Bug fix labels May 8, 2024
@matks
Copy link
Contributor

matks commented Jun 7, 2024

Accurate change is It replaces "Manufacturer" by "Brand" in the CSV example file -> added to PR description

Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @fulldecent I have improved the "How to test" section of your Pull Request to make it crystal clear what you are improving. PrestaShop is a big software, not everyone knows every feature it has, and the Import feature is not the more well known.

Could you please run the UI Tests with your PR? And paste in your PR description the link to the run. Read this page to know why and how to use this tool..

@matks matks added the Waiting for author Status: action required, waiting for author feedback label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Type: Bug fix develop Branch Waiting for author Status: action required, waiting for author feedback
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

None yet

3 participants