-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to enable MariaDB in CI #36049
base: develop
Are you sure you want to change the base?
Try to enable MariaDB in CI #36049
Conversation
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! (Note: this is an automated message, but answering it will reach a real human) |
e6d9877
to
3118469
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I can't see the cause of the integration test failure.
- name: Change MySQL authentication method | ||
run: mysql -h127.0.0.1 -uroot -ppassword -e "ALTER USER 'root'@'%' IDENTIFIED WITH mysql_native_password BY 'password'; FLUSH PRIVILEGES;" | ||
- name: Change MariaDB authentication method | ||
run: mysql -h127.0.0.1 -uroot -ppassword -e "ALTER USER root@localhost IDENTIFIED VIA mysql_native_password USING PASSWORD('password'); FLUSH PRIVILEGES;" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This chunk isn't needed. The mysql root password
of the getlong/mariadb-action
will set the password. Also `FLUSH PRIVILEGES isn't required after any ALTER USER or other SQL statement granting privs/user changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to remove it, but it fails too. I don't know why, I can't debug the error https://github.com/PrestaShop/PrestaShop/actions/runs/8892768244/job/24417552756?pr=36049
if you have any idea ...
I tested locally on PrestaShop 44c66da Against MariaDB-11.5 (with my delete single table alias extensions MariaDB/server#3237)
Against MariaDB-10.11.8- ae03374f29944f4ae5cbc4df80d7273f2476dcff (current latest) / and 10.4.34-f378e7643459f0baa6c4149a795463f2f46b6871 (current latest).
Still can't see why gh actions fails on "create-test-db" |
@grooverdan thank you for your tests. |
Glad one of does have it working ok :-). Maybe mariadb not fully running for some reason. As a step before testing
|
Every detail helps: versions, browser/server configuration, specific module/theme, etc. Feel free to add more information below this table.