Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade locked version of phpunit #32665

Closed
wants to merge 1 commit into from

Conversation

mvorisek
Copy link
Contributor

Questions Answers
Branch? develop
Description? Upgrade locked phpunit and related deps to the latest version.
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
How to test? CI must pass
Fixed ticket? n/a
Related PRs n/a
Sponsor company MAHALUX

@mvorisek mvorisek requested a review from a team as a code owner May 23, 2023 10:00
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels May 23, 2023
@mvorisek
Copy link
Contributor Author

001 Scenario: Delete all products from order then add product in the empty order # Features/Scenario/Order/order_from_bo.feature:693
      And order "bo_order1" should have following tax details:                   # Features/Scenario/Order/order_from_bo.feature:734
        Invalid order tax field unit_amount, expected 0.9 instead of 0.9
        Failed asserting that 0.8999999999999999 matches expected 0.9.

002 Scenario: I use and address without taxes (no order_detail_tax created), then I change to a country with taxes all is correctly computed # Features/Scenario/Order/order_shipping.feature:728
      And the first invoice from order "bo_order1" should have following shipping tax details:                                               # Features/Scenario/Order/order_shipping.feature:836
        Invalid order tax field total_amount, expected 0.36 instead of 0.36
        Failed asserting that 0.3600000000000003 matches expected 0.36.

003 Scenario: In rounding per item mode, I use an address without taxes (no order_detail_tax created), then I change to a country with taxes all is correctly computed # Features/Scenario/Order/order_shipping.feature:871
      And the first invoice from order "bo_order1" should have following shipping tax details:                                                                         # Features/Scenario/Order/order_shipping.feature:980
        Invalid order tax field total_amount, expected 0.36 instead of 0.36
        Failed asserting that 0.3600000000000003 matches expected 0.36.

1189 scenarios (1186 passed, 3 failed)

feature: https://github.com/PrestaShop/PrestaShop/blob/bdee2c642/tests/Integration/Behaviour/Features/Scenario/Order/order_from_bo.feature#L736

see sebastianbergmann/comparator#102 for the reason, the number needs to be probably rounded somewhere as tweaking the test might not be desired

What is the wanted fix?

@mvorisek
Copy link
Contributor Author

mvorisek commented Sep 4, 2023

closing as no reaction

@mvorisek mvorisek closed this Sep 4, 2023
@mvorisek mvorisek deleted the upgrade_phpunit_deps branch September 4, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
develop Branch Improvement Type: Improvement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants