Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use string value for CSRF token in DeliveryControllerTest #12804

Merged
merged 1 commit into from Mar 6, 2019
Merged

Use string value for CSRF token in DeliveryControllerTest #12804

merged 1 commit into from Mar 6, 2019

Conversation

matks
Copy link
Contributor

@matks matks commented Mar 6, 2019 •
edited

Questions Answers
Branch? develop
Description? Use string value for CSRF token in DeliveryControllerTest to comply with Symfony v3.4.23. Else our unit tests break with this Symfony version because of symfony/symfony#29884
Type? improvement
Category? TE
BC breaks? no
Deprecations? no
Fixed ticket?
How to test? All Travis builds should be green, including HIGH_DEPS

This change is Reviewable

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Mar 6, 2019
@matks matks mentioned this pull request Mar 6, 2019
Merged
@matks
Copy link
Contributor Author

matks commented Mar 6, 2019

Travis is green ✅

Thank you for the reviews

@matks matks added this to the 1.7.6.0 milestone Mar 6, 2019
@matks matks merged commit ccc08ff into PrestaShop:develop Mar 6, 2019
@matks matks deleted the send-string-csrf-token-for-tests branch March 6, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreRambaud PierreRambaud PierreRambaud approved these changes

@Quetzacoalt91 Quetzacoalt91 Quetzacoalt91 approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matks @PierreRambaud @Quetzacoalt91 @prestonBot