Upgrade pydantic to version 1.7.x #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinned below 1.6 waiting for an issue that was solved a while back
zanieb
changed the title
|
Passing checks in Cloud so I think this is good to go! @cicdw |
cicdw
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinned below 1.6 waiting for an issue that was solved a while back
Summary
Pydantic was pinned below 1.6 pending the fix for pydantic/pydantic#1710 which has long since been patched in pydantic/pydantic#1712. Let's see how 1.7 does, I'll cross-test in cloud as well.
Importance
I desire the
PrivateAttrfunctionality and it's good to stay up to date since this underpins our ORMs.Checklist
This PR:
[ ] adds new tests (if appropriate)changes/directory (if appropriate)