Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with PyGithub >= 1.55 #4440

Merged
merged 4 commits into from Apr 26, 2021
Merged

Fix compatibility with PyGithub >= 1.55 #4440

merged 4 commits into from Apr 26, 2021

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Apr 26, 2021

Summary

We construct some GithubExceptions in tests which have been changed in the newest PyGithub release to require headers to be passed per PyGithub/PyGithub#1887

Changes

Passes fake headers to the test exceptions

Importance

Tests will not pass in CI using the newest PyGithub

Checklist

This PR:

  • [ ] adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)
  • [ ] updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

@zanieb zanieb requested a review from jcrist as a code owner April 26, 2021 19:55
@zanieb zanieb requested a review from zangell44 April 26, 2021 19:57
CI cannot pass on either branch separately. Rolling into a single PR.
@zanieb zanieb merged commit 965a318 into master Apr 26, 2021
@zanieb zanieb deleted the fix-pygithub branch April 26, 2021 20:40
@zanieb zanieb mentioned this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants