Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow client-provided ID when creating a task run #13276

Merged
merged 8 commits into from May 13, 2024

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented May 7, 2024

When working on the new task run engine, we identified an opportunity to remove our API as a bottleneck when submitting tasks to remote infrastructure, allowing the client to generate a UUID and provide that as the ID when creating a task run. Using a client-generated ID will enable us to submit to the task execution layer before creating a task run on the server while also allowing future enhancements where the client can track dependencies between runs.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • This pull request includes a label categorizing the change e.g. maintenance, fix, feature, enhancement, docs.

For documentation changes:

  • This pull request includes redirect settings in netlify.toml for files that are removed or renamed.

For new functions or classes in the Python SDK:

  • This pull request includes helpful docstrings.
  • If a new Python file was added, this pull request contains a stub page in the Python SDK docs and an entry in mkdocs.yml navigation.

Copy link

netlify bot commented May 7, 2024

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit b63b6f8
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/664234944fab850008494de7
😎 Deploy Preview https://deploy-preview-13276--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@desertaxle desertaxle added the experimental Related to an experimental feature label May 7, 2024
@desertaxle desertaxle marked this pull request as ready for review May 9, 2024 05:20
@desertaxle desertaxle requested review from zangell44 and a team as code owners May 9, 2024 05:20
@desertaxle desertaxle requested review from jlowin and cicdw and removed request for a team and zangell44 May 9, 2024 05:20
Copy link
Collaborator

@chrisguidry chrisguidry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sharp!

@desertaxle desertaxle merged commit aabceec into main May 13, 2024
58 checks passed
@desertaxle desertaxle deleted the client-side-task-run-ids branch May 13, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Related to an experimental feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants