feat: warn when SQL parameters are unused #9841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwalters512
reviewed
May 10, 2024
All images
|
nwalters512
reviewed
May 15, 2024
| IdSchema, | ||
| ); | ||
| if (updated == null) { | ||
| if (item.id) { |
There was a problem hiding this comment.
I feel a bit hesitant to check for truthy instead of for explicit null/undefined.
Suggested change
| if (item.id) { | |
| if (item.id != null) { |
There was a problem hiding this comment.
Good catch, I'll fix that.
| sql.select_assessment_instance_group, | ||
| { | ||
| assessment_id, | ||
| uid: json.uid, |
There was a problem hiding this comment.
I believe this is not used, right?
There was a problem hiding this comment.
Right, I'll fix that too. I guess I was expecting a test to fail but maybe we never run something on that branch.
nwalters512
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks in realtime to see if a SQL query was passed more parameters than were used in the query and logs with a warning.