Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jupyterlab example question to use new workspace image #9827

Merged
merged 5 commits into from May 23, 2024

Conversation

jonatanschroeder
Copy link
Member

As discussed on Slack. This image was recently created but there was no question in the example course using the new image. Also, we want to encourage instructors to use the new image where appropriate.

Copy link
Contributor

github-actions bot commented May 8, 2024

All images

Image Platform Old Size New Size Change
prairielearn/executor:0b23fbc126e5b14dbf90bbe2af7dd54428e270a2 null 1635.48 MB 1635.49 MB 0.00%
prairielearn/prairielearn:0b23fbc126e5b14dbf90bbe2af7dd54428e270a2 linux/amd64 1635.47 MB 1635.48 MB 0.00%

Copy link
Contributor

@nwalters512 nwalters512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to leave any remaining references to the old image? I count two categories remaining:

  • A reference in docs/workspace.md
  • A number of questions in exampleCourse/questions/demo/annotated/

@jonatanschroeder
Copy link
Member Author

Is there any reason to leave any remaining references to the old image? I count two categories remaining:

  • A reference in docs/workspace.md
  • A number of questions in exampleCourse/questions/demo/annotated/

I have updated these, but because of #9828 my testing ability locally is a bit limited. I was able to open the workspaces and all, but not test the submission. Can you double-check that it's working as expected?

@jonatanschroeder jonatanschroeder added this pull request to the merge queue May 23, 2024
Merged via the queue into master with commit 483b5ce May 23, 2024
7 checks passed
@jonatanschroeder jonatanschroeder deleted the jupyterlab-example-course branch May 23, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants