-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize instructor course admin staff page #9822
Conversation
All images
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm blocking on the global hasUnknownUsers
variable.
apps/prairielearn/src/pages/instructorCourseAdminStaff/instructorCourseAdminStaff.html.ts
Outdated
Show resolved
Hide resolved
apps/prairielearn/src/pages/instructorCourseAdminStaff/instructorCourseAdminStaff.html.ts
Outdated
Show resolved
Hide resolved
apps/prairielearn/src/pages/instructorCourseAdminStaff/instructorCourseAdminStaff.html.ts
Outdated
Show resolved
Hide resolved
apps/prairielearn/src/pages/instructorCourseAdminStaff/instructorCourseAdminStaff.html.ts
Outdated
Show resolved
Hide resolved
apps/prairielearn/src/pages/instructorCourseAdminStaff/instructorCourseAdminStaff.html.ts
Outdated
Show resolved
Hide resolved
apps/prairielearn/src/pages/instructorCourseAdminStaff/instructorCourseAdminStaff.html.ts
Outdated
Show resolved
Hide resolved
apps/prairielearn/src/pages/instructorCourseAdminStaff/instructorCourseAdminStaff.html.ts
Outdated
Show resolved
Hide resolved
…torCourseAdminStaff.html.ts Co-authored-by: Nathan Sarang-Walters <nathan@prairielearn.com>
…torCourseAdminStaff.html.ts Co-authored-by: Nathan Sarang-Walters <nathan@prairielearn.com>
…torCourseAdminStaff.html.ts Co-authored-by: Nathan Sarang-Walters <nathan@prairielearn.com>
…torCourseAdminStaff.html.ts Co-authored-by: Nathan Sarang-Walters <nathan@prairielearn.com>
apps/prairielearn/src/pages/instructorCourseAdminStaff/instructorCourseAdminStaff.html.ts
Outdated
Show resolved
Hide resolved
…torCourseAdminStaff.html.ts Co-authored-by: Nathan Sarang-Walters <nathan@prairielearn.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9822 +/- ##
==========================================
+ Coverage 66.43% 66.76% +0.33%
==========================================
Files 453 454 +1
Lines 70289 71020 +731
Branches 5648 5676 +28
==========================================
+ Hits 46694 47414 +720
- Misses 23170 23182 +12
+ Partials 425 424 -1 ☔ View full report in Codecov by Sentry. |
This PR intends to convert the
instructorCourseAdminStaff
page from Javascript and EJS to TypeScript and HTML template literals.