Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize instructor course admin staff page #9822

Merged
merged 16 commits into from May 22, 2024

Conversation

mylesw27
Copy link
Collaborator

@mylesw27 mylesw27 commented May 7, 2024

This PR intends to convert the instructorCourseAdminStaff page from Javascript and EJS to TypeScript and HTML template literals.

Copy link
Contributor

github-actions bot commented May 7, 2024

All images

Image Platform Old Size New Size Change
prairielearn/executor:4fb7f4281eabbfdf430e89282d53fef1985fdeae null 1645.00 MB 1645.01 MB 0.00%
prairielearn/prairielearn:4fb7f4281eabbfdf430e89282d53fef1985fdeae linux/amd64 1645.01 MB 1645.01 MB -0.00%

@mylesw27 mylesw27 marked this pull request as ready for review May 15, 2024 17:54
@mylesw27 mylesw27 requested a review from nwalters512 May 15, 2024 17:54
Copy link
Contributor

@nwalters512 nwalters512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm blocking on the global hasUnknownUsers variable.

mylesw27 and others added 5 commits May 17, 2024 09:42
…torCourseAdminStaff.html.ts

Co-authored-by: Nathan Sarang-Walters <nathan@prairielearn.com>
…torCourseAdminStaff.html.ts

Co-authored-by: Nathan Sarang-Walters <nathan@prairielearn.com>
…torCourseAdminStaff.html.ts

Co-authored-by: Nathan Sarang-Walters <nathan@prairielearn.com>
…torCourseAdminStaff.html.ts

Co-authored-by: Nathan Sarang-Walters <nathan@prairielearn.com>
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 98.21429% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 66.76%. Comparing base (6cf6a1e) to head (4fb7f42).
Report is 1 commits behind head on master.

Files Patch % Lines
...ourseAdminStaff/instructorCourseAdminStaff.html.ts 98.26% 13 Missing ⚠️
...ctorCourseAdminStaff/instructorCourseAdminStaff.ts 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9822      +/-   ##
==========================================
+ Coverage   66.43%   66.76%   +0.33%     
==========================================
  Files         453      454       +1     
  Lines       70289    71020     +731     
  Branches     5648     5676      +28     
==========================================
+ Hits        46694    47414     +720     
- Misses      23170    23182      +12     
+ Partials      425      424       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mylesw27 mylesw27 added this pull request to the merge queue May 22, 2024
Merged via the queue into master with commit f6c3170 May 22, 2024
9 checks passed
@mylesw27 mylesw27 deleted the modernize-instructor-course-admin-staff branch May 22, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants