Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable copying of publicly shared question code (if allowed by instructor) #9800

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

SethPoulsen
Copy link
Collaborator

implements parts of #9397

Copy link
Contributor

github-actions bot commented May 1, 2024

All images

Image Platform Old Size New Size Change
prairielearn/executor:b941d07f24c161caf92791ca5b755d507f65f8de null 1187.93 MB 1187.76 MB -0.01%
prairielearn/prairielearn:b941d07f24c161caf92791ca5b755d507f65f8de linux/amd64 1187.91 MB 1187.76 MB -0.01%

@SethPoulsen SethPoulsen marked this pull request as ready for review May 28, 2024 00:58
@SethPoulsen
Copy link
Collaborator Author

I am aware that this doesn't actually make a way to mark the publicly_shared_source column as true in the database.

Doing that is going to be a bunch of UI design/mess on the question settings page, I thought it would be nice to do that in a separate PR from this.

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 66.89%. Comparing base (22ab7c4) to head (b941d07).

Files Patch % Lines
...CopyPublicQuestion/instructorCopyPublicQuestion.ts 0.00% 2 Missing ⚠️
apps/prairielearn/src/lib/copy-question.ts 50.00% 1 Missing ⚠️
apps/prairielearn/src/server.js 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9800      +/-   ##
==========================================
- Coverage   67.01%   66.89%   -0.13%     
==========================================
  Files         458      458              
  Lines       71353    71351       -2     
  Branches     5720     5703      -17     
==========================================
- Hits        47820    47732      -88     
- Misses      23104    23194      +90     
+ Partials      429      425       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant