-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ubuntu from 22.04 to 24.04 in /workspaces/desktop #9794
Bump ubuntu from 22.04 to 24.04 in /workspaces/desktop #9794
Conversation
Bumps ubuntu from 22.04 to 24.04. --- updated-dependencies: - dependency-name: ubuntu dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
All images
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it seems to work as expected. Should wait to merge until after the finals season to avoid breaking any existing course.
Something I've been noodling over: should we find a way to publish images with specific tags? e.g. we could have been publishing master as I don't think we have to do that before landing this PR, just food for thought. |
I'm on board with that, assuming there's tooling for it, though we might want to consider what happens if we find a bug that affects multiple tags (or only a previous tag). Do we support the older versions? Also, would it be a better option to move graders and workspaces to separate repos? |
We'll of course need to build such tooling 🙂
I don't think we've ever patched an older version of a workspace/grader. Even if we wanted to do that, we haven't had a way to do that in the past (what would we tag the new old version as?). If we're talking about the hypothetical future where we want to re-tag an older version... I think we could do that in exceptional circumstances, but most of the time I think we'd just tell folks to use the latest image. If we really wanted to optimize for that case, I'd suggest that we do something like what the Node Docker image repo does and place each version/OS combination into its own directory, so we could always go back and modify old images.
IMO we should keep all core workspaces in the source tree for now. |
Bumps ubuntu from 22.04 to 24.04.
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)