Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add authors field to info.json for questions #9790

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

SethPoulsen
Copy link
Collaborator

@SethPoulsen SethPoulsen commented Apr 30, 2024

As part of shipping the question sharing featues (#9397), we would like to ensure that quesiton authors are able to get credit for their work, and so we are creating the ability to denote the authors of a question in the JSON, which will automatically be copied when people copy questions.

Some remaining items to discuss about this before pushing:

  • do we want an authors table as well?
  • what should be the piece of information we de-dupe authors across? email? (and if people use different names with the same email, what do we do then?)
  • what syntax do we want to use to allow people to put names and emails into these strings?

Comment on lines 178 to 180
tags?: string[];
authors?: string[];
clientFiles?: string[];
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do the tests have entirely separate type declarations for the JSON file schemas than the main codebase has in course-db.ts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run make update-database-description in the docker container, it changes the owner flag on these files to be the root user. Any way around this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe it just changes the permissions on them somehow? anyway, whatever it is doing, git is not happy about it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an alias in my shell that runs make update-database-description followed by sudo chown -R jonatan.jonatan ~/pl/database. If you find a way to make the files in docker containers run as a specific user let me know, I haven't been able to do that.

Copy link
Contributor

github-actions bot commented Apr 30, 2024

All images

Image Platform Old Size New Size Change
prairielearn/executor:125c6653cf52d758d6bb43bef4b6da846ace6de5 null 1627.45 MB 1627.62 MB 0.01%
prairielearn/prairielearn:125c6653cf52d758d6bb43bef4b6da846ace6de5 linux/amd64 1627.44 MB 1627.62 MB 0.01%

@SethPoulsen SethPoulsen changed the title feat: Add authors filed to info.json for questions feat: Add authors field to info.json for questions May 8, 2024
@jonatanschroeder
Copy link
Member

I was looking at old issues, and #1824 may be resolved here.

@SethPoulsen
Copy link
Collaborator Author

thanks for linking that Jonaton. It looks like some of the decision decisions around this have changed since then, we should discuss this more probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants