-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add authors field to info.json for questions #9790
base: master
Are you sure you want to change the base?
Conversation
tags?: string[]; | ||
authors?: string[]; | ||
clientFiles?: string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do the tests have entirely separate type declarations for the JSON file schemas than the main codebase has in course-db.ts?
database/tables/questions.pg
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run make update-database-description
in the docker container, it changes the owner flag on these files to be the root user. Any way around this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe it just changes the permissions on them somehow? anyway, whatever it is doing, git is not happy about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have an alias in my shell that runs make update-database-description
followed by sudo chown -R jonatan.jonatan ~/pl/database
. If you find a way to make the files in docker containers run as a specific user let me know, I haven't been able to do that.
All images
|
I was looking at old issues, and #1824 may be resolved here. |
thanks for linking that Jonaton. It looks like some of the decision decisions around this have changed since then, we should discuss this more probably. |
As part of shipping the question sharing featues (#9397), we would like to ensure that quesiton authors are able to get credit for their work, and so we are creating the ability to denote the authors of a question in the JSON, which will automatically be copied when people copy questions.
Some remaining items to discuss about this before pushing: