Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C Grader: upgrade to Ubuntu 24.04 #9785

Merged
merged 6 commits into from May 17, 2024
Merged

C Grader: upgrade to Ubuntu 24.04 #9785

merged 6 commits into from May 17, 2024

Conversation

jonatanschroeder
Copy link
Member

Update C grader to latest Ubuntu LTS version.

@jonatanschroeder jonatanschroeder added the do not merge This pull request should not be merged yet label Apr 29, 2024
@jonatanschroeder jonatanschroeder mentioned this pull request Apr 29, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited

All images

Image Platform Old Size New Size Change
prairielearn/executor:d09ffa1535c3174f9004ee4418a371847a1a04d1 null 1635.48 MB 1635.48 MB -0.00%
prairielearn/grader-c:d09ffa1535c3174f9004ee4418a371847a1a04d1 linux/amd64 314.83 MB 325.67 MB 3.44%
prairielearn/grader-c:d09ffa1535c3174f9004ee4418a371847a1a04d1 linux/arm64 282.07 MB 301.68 MB 6.95%
prairielearn/prairielearn:d09ffa1535c3174f9004ee4418a371847a1a04d1 linux/amd64 1635.47 MB 1635.48 MB 0.00%

eliotwrobson
eliotwrobson approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@eliotwrobson eliotwrobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, but not super important and Python changes look good overall.

graders/c/Dockerfile Show resolved Hide resolved
graders/c/cgrader/cgrader.py Show resolved Hide resolved
@jonatanschroeder jonatanschroeder mentioned this pull request May 1, 2024
Closed
nwalters512
nwalters512 approved these changes May 15, 2024
View reviewed changes
graders/c/Dockerfile Show resolved Hide resolved
@jonatanschroeder jonatanschroeder added this pull request to the merge queue May 17, 2024
Merged via the queue into master with commit ed6d50f May 17, 2024
7 checks passed
@jonatanschroeder jonatanschroeder deleted the c-grader-ubuntu-2404 branch May 17, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwalters512 nwalters512 nwalters512 approved these changes

@eliotwrobson eliotwrobson eliotwrobson approved these changes

Assignees
No one assigned
Labels
do not merge This pull request should not be merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonatanschroeder @eliotwrobson @nwalters512