Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize instructor assessment uploads #9777

Merged
merged 14 commits into from May 16, 2024

Conversation

mylesw27
Copy link
Collaborator

This PR intends to convert the instructorAssessmentUploads page from JavaScript and EJS to TypeScript and HTML template literals.

Copy link
Contributor

github-actions bot commented Apr 25, 2024

All images

Image Platform Old Size New Size Change
prairielearn/executor:5f649438fcbd5a859aee71b18820b371db147961 null 1648.27 MB 1648.35 MB 0.01%
prairielearn/prairielearn:5f649438fcbd5a859aee71b18820b371db147961 linux/amd64 1648.26 MB 1648.35 MB 0.00%

@mylesw27 mylesw27 marked this pull request as ready for review April 25, 2024 23:34
@mylesw27 mylesw27 self-assigned this Apr 26, 2024
Copy link
Member

@jonatanschroeder jonatanschroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial findings.

mylesw27 and others added 4 commits April 29, 2024 13:14
…ctorAssessmentUploads.html.ts

Co-authored-by: Jonatan Schroeder <jonatan@yorku.ca>
…ctorAssessmentUploads.html.ts

Co-authored-by: Jonatan Schroeder <jonatan@yorku.ca>
Copy link
Contributor

@nwalters512 nwalters512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor note, but other than this, good to go!

Copy link
Contributor

@nwalters512 nwalters512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to reformat with make format-js before we can land this!

@mylesw27 mylesw27 requested a review from nwalters512 May 16, 2024 00:23
@mylesw27 mylesw27 added this pull request to the merge queue May 16, 2024
Merged via the queue into master with commit a4aa68c May 16, 2024
7 checks passed
@mylesw27 mylesw27 deleted the modernize-instructor-assessment-uploads branch May 16, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants