-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize instructor assessment uploads #9777
Conversation
All images
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial findings.
apps/prairielearn/src/pages/instructorAssessmentUploads/instructorAssessmentUploads.ts
Outdated
Show resolved
Hide resolved
apps/prairielearn/src/pages/instructorAssessmentUploads/instructorAssessmentUploads.html.ts
Outdated
Show resolved
Hide resolved
apps/prairielearn/src/pages/instructorAssessmentUploads/instructorAssessmentUploads.html.ts
Outdated
Show resolved
Hide resolved
apps/prairielearn/src/pages/instructorAssessmentUploads/instructorAssessmentUploads.html.ts
Outdated
Show resolved
Hide resolved
…ctorAssessmentUploads.html.ts Co-authored-by: Jonatan Schroeder <jonatan@yorku.ca>
…ctorAssessmentUploads.html.ts Co-authored-by: Jonatan Schroeder <jonatan@yorku.ca>
apps/prairielearn/src/pages/instructorAssessmentUploads/instructorAssessmentUploads.html.ts
Outdated
Show resolved
Hide resolved
apps/prairielearn/src/pages/instructorAssessmentUploads/instructorAssessmentUploads.html.ts
Outdated
Show resolved
Hide resolved
apps/prairielearn/src/pages/instructorAssessmentUploads/instructorAssessmentUploads.html.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor note, but other than this, good to go!
apps/prairielearn/src/pages/instructorAssessmentUploads/instructorAssessmentUploads.html.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to reformat with make format-js before we can land this!
This PR intends to convert the
instructorAssessmentUploads
page from JavaScript and EJS to TypeScript and HTML template literals.