Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize Instructor Assessment Instances Page #9725

Merged
merged 21 commits into from May 16, 2024
Merged

Modernize Instructor Assessment Instances Page #9725

merged 21 commits into from May 16, 2024

Conversation

mylesw27
Copy link
Collaborator

This PR intends to convert the instructorAssessmentInstances page from JavaScript and EJS to TypeScript and HTML template literals. This PR was a little bit tricky due to the client script that this page uses. This script file has now been moved to .../scripts/instructorAssessmentInstancesClient.ts and could probably use a thorough review here as I had to add types as well as update some deprecated methods.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited

All images

Image Platform Old Size New Size Change
prairielearn/executor:950e7675deaabc46fb5711299a8dea15f6a7e6ad null 1648.27 MB 1648.31 MB 0.00%
prairielearn/prairielearn:950e7675deaabc46fb5711299a8dea15f6a7e6ad linux/amd64 1648.26 MB 1648.31 MB 0.00%

@mylesw27 mylesw27 marked this pull request as ready for review April 16, 2024 23:48
nwalters512
nwalters512 reviewed Apr 17, 2024
View reviewed changes
apps/prairielearn/assets/scripts/instructorAssessmentInstancesClient.ts Outdated Show resolved Hide resolved
apps/prairielearn/assets/scripts/instructorAssessmentInstancesClient.ts Outdated Show resolved Hide resolved
apps/prairielearn/assets/scripts/instructorAssessmentInstancesClient.ts Outdated Show resolved Hide resolved
apps/prairielearn/assets/scripts/instructorAssessmentInstancesClient.ts Outdated Show resolved Hide resolved
apps/prairielearn/assets/scripts/instructorAssessmentInstancesClient.ts Outdated Show resolved Hide resolved
apps/prairielearn/assets/scripts/instructorAssessmentInstancesClient.ts Outdated Show resolved Hide resolved
apps/prairielearn/assets/scripts/instructorAssessmentInstancesClient.ts Outdated Show resolved Hide resolved
apps/prairielearn/src/pages/instructorAssessmentInstances/instructorAssessmentInstances.html.ts Outdated Show resolved Hide resolved
apps/prairielearn/src/pages/instructorAssessmentInstances/instructorAssessmentInstances.html.ts Outdated Show resolved Hide resolved
apps/prairielearn/src/pages/instructorAssessmentInstances/instructorAssessmentInstances.ts Outdated Show resolved Hide resolved
@mylesw27 mylesw27 self-assigned this Apr 19, 2024
nwalters512
nwalters512 approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@nwalters512 nwalters512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to reformat with make format-js before we can land this!

@mylesw27 mylesw27 requested a review from nwalters512 May 15, 2024 23:39
@mylesw27 mylesw27 added this pull request to the merge queue May 16, 2024
Merged via the queue into master with commit 351d98e May 16, 2024
7 checks passed
@mylesw27 mylesw27 deleted the instructor-assessment-instances-typescript branch May 16, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatanschroeder jonatanschroeder jonatanschroeder left review comments

@nwalters512 nwalters512 nwalters512 approved these changes

Assignees

@mylesw27 mylesw27

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mylesw27 @jonatanschroeder @nwalters512