Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Java grader to Java 21 and Ubuntu 24.04 #9685

Merged
merged 11 commits into from
May 17, 2024
Merged

Conversation

jonatanschroeder
Copy link
Member

This is for now a draft for testing purpose. Both Java 21 and Ubuntu 24.04 are LTS, though Ubuntu is still in beta until late April.

@jonatanschroeder jonatanschroeder added the do not merge This pull request should not be merged yet label Apr 4, 2024
Copy link
Contributor

github-actions bot commented Apr 4, 2024

All images

Image Platform Old Size New Size Change
prairielearn/executor:9702fcf13cfbaff55b09b76f05b4edcd4f69f2ae null 1635.48 MB 1635.48 MB 0.00%
prairielearn/grader-java:9702fcf13cfbaff55b09b76f05b4edcd4f69f2ae linux/amd64 365.36 MB 228.81 MB -37.37%
prairielearn/grader-java:9702fcf13cfbaff55b09b76f05b4edcd4f69f2ae linux/arm64 347.92 MB 226.04 MB -35.03%
prairielearn/prairielearn:9702fcf13cfbaff55b09b76f05b4edcd4f69f2ae linux/amd64 1635.47 MB 1635.48 MB 0.00%

Comment on lines -171 to +175
- `-ea` to enable [Java assertions](https://docs.oracle.com/javase/7/docs/technotes/guides/language/assert.html).
- `-source 10` to compile using the Java 10 language version.

Similarly, you may set specific options to the `java` command line using the `JDK_JAVA_OPTIONS`. A list of valid options can be found in the [`java' documentation page](https://docs.oracle.com/en/java/javase/21/docs/specs/man/java.html#standard-options-for-java). Some options of interest may include:

- `-Dproperty=value` to set system properties that may be retrieved with `System.getProperty(name)`;
- `-ea` to enable [Java assertions](https://docs.oracle.com/javase/8/docs/technotes/guides/language/assert.html).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was an error in the documentation. -ea is an option of java (the VM runner), not javac (the compiler).

@jonatanschroeder jonatanschroeder marked this pull request as ready for review May 1, 2024 15:56
@jonatanschroeder jonatanschroeder added this pull request to the merge queue May 17, 2024
Merged via the queue into master with commit 2ccf20c May 17, 2024
7 checks passed
@jonatanschroeder jonatanschroeder deleted the java-grader-21 branch May 17, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge This pull request should not be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants