Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Cleanup { } Function Block #9900
Implement Cleanup { } Function Block #9900
Changes from 10 commits
aba2867
307a9fa
c1dfae7
b9703a4
82dbf03
e994415
68c6319
cf34ce6
55bee93
f114cf7
fdb2f83
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment for
private const string CommandProxyTemplate
needs to be updated.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of the
try
/catch
here if we just immediatelythrow
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea. I just copied the existing patterns for these generated strings. All of them have a
try/catch
where thecatch
does nothing other thanthrow
.I'm all for removing it, but didn't want to touch it in case there's some weird edge case that proxy commands need this to be here for. Even then, though, I'm pretty sure the weirdness around
throw
means this should instead bethrow $_
(iirc there are some slight differences in the result, there's an old issue around it that nobody's been game to touch for years).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the scenario for exposing this method publicly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be misremembering, but I think I just copied the existing access modifiers for the other blocks? If not we can make it private, it doesn't need to be different to the others here. IIRC this would be used by...
New-ProxyCommand
, I think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was wondering if it's because PowerShell script needs it somewhere in that strange internal but exposed twilight zone...