Create the Windows.x64 global tool with shim for signing #21559
Merged
+233
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
requested review from
daxian-dbw,
TravisEz13 and
anmenaga
as code owners
TravisEz13
reviewed
May 3, 2024
| Write-Verbose -Verbose -Message "pathForUpload: $pathForUpload" | ||
| Copy-Item -Path '${{ parameters.binPath }}\*' -Destination $pathForUpload -Recurse -Force -Verbose | ||
| Write-Verbose -Verbose -Message "Files copied to $pathForUpload" | ||
| $isGlobalTool = '${{ parameters.globalTool }}' -eq 'true' |
There was a problem hiding this comment.
Not blocking. We should move any PS Script of significant size into a script or module. This does two things, makes sure they are scanned by static analysis tools and reduces total yaml size.
TravisEz13
reviewed
May 3, 2024
| Remove-Item -Path $ridFolder/runtimes/win-arm -Recurse -Force | ||
| $toolSettings = $packagingStrings.GlobalToolSettingsFile -f "pwsh.dll" | ||
| } | ||
| # Due to needing a signed shim for the global tool, we build the global tool in build instead of packaging. |
There was a problem hiding this comment.
I wanted to keep the code and document why we don't build Windows.x64 here.
adityapatwardhan
added
BackPort-7.4.x-Approved
Backport-7.2.x-Approved
and removed
BackPort-7.4.x-Consider
Backport-7.2.x-Consider
labels
daxian-dbw
added
the
CL-BuildPackaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #20557
The global tool for Windows.x64 is created using dotnet pack so that shim can be generated during the build for signing.
The tool uses a new csproj with added properties for generating the shim, we added the build to fxdependent stage.
More details about shim are documented here: https://github.com/dotnet/sdk/blob/main/documentation/general/signing-global-tool-packages.md
The way the build works is a bit tricky as when it is built, we cannot add the modules that come from gallery.
We have to use
dotnet packto build the nupkg and then expand it as a zip.After expanding we restore the signed files for the modules from the gallery.
We also delete
contentandcontentFilesfolder which are not necessary.After that, we repack using Compress-Archive and rename it back to a nupkg.
PR Context
dotnet-sdk images show that the exe is unsigned and fails compliance requirements.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).