New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test fixes which fail during release testing. #20028
Test fixes which fail during release testing. #20028
Conversation
A number of changes to reduce test failures during release test. Skip all tests for Send-MailMessage, this cmdlet is deprecated. Improve robustness for remove certificates in AfterAll. Check status of reply for test-connection before checking address.
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed all but tab completion
A number of changes to reduce test failures during release test. Skip all tests for Send-MailMessage, this cmdlet is deprecated. Improve robustness for remove certificates in AfterAll. Check status of reply for test-connection before checking address.
PR Summary
PR Context
The only controversial change may be the skipping of tests for
Send-MailMessage
. Since this cmdlet is deprecated and unsupported, we probably don't need to test it. We still include it, and compliance checks will still occur, but functional tests may now be skipped. These tests are not consistent in our release tests and cause additional inspections when we do a release build.PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).