Unsealed IDisposable should contain protected virtual void Dispose(bool) method

[xtqqczze]

PR Summary

PR Context

Fix code smell: https://rules.sonarsource.com/csharp/RSPEC-3881

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• Breaking changes
  • None
  • OR
  • Experimental feature(s) needed
    • Experimental feature name(s):
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
• Tooling
  • I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
  • OR
  • I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
    • Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
    • Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
    • Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
    • Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[xtqqczze]

PowerShell-CI-linux failed in build 45608: Invoke-WebRequest tests.Denial of service.Image Parsing Issue opened: #11821

[PaulHigin]

Adding committee review tag. I am not sure if these changes should be made.

[iSazonov]

Perhaps it makes sense for public (not sealed) classes.

[SteveL-MSFT]

@PowerShell/powershell-committee reviewed this, we should not make any unnecessary changes to private/internal classes. We should review public classes if the change makes sense. Additionally, going forward, we would appreciate if the summary section is filled out to provide context on the reasons for making this change and enable the committee to have more productive conversations during review.

[iSazonov]

@xtqqczze Do you want to continue with reviewing public classes?

[iSazonov]

@xtqqczze Friendly ping.

[ghost]

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

[iSazonov]

@xtqqczze Do you want to continue?

[xtqqczze]

@iSazonov yes please, thanks for the reminder

[ghost]

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Mainainer, Please provide feedback and/or mark it as Waiting on Author

[xtqqczze]

Rebased for CI, this PR is ready for review.

[iSazonov]

I would not change this old code without urgent need.

/cc @daxian-dbw @PaulHigin for conclusion.

[PaulHigin]

I looked through these changes and agree with @iSazonov that they don't really provide much value with some small risk. Some classes are internal and should be 'sealed' because they are not meant to be derived from. Others are public and also should probably be sealed.

I appreciate the effort to find and make these changes, but I feel we shouldn't submit the changes because there is no compelling reason to.

[ghost]

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author