Skip to content

Commit

Permalink
Switch to using GitHub action to verify markdown links for PRs (#17281)
Browse files Browse the repository at this point in the history
  • Loading branch information
TravisEz13 committed May 31, 2022
1 parent 30aa6c7 commit 7249200
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 15 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/markdown-link/config.json
@@ -0,0 +1,3 @@
{
"aliveStatusCodes": [504, 503, 403, 200]
}
20 changes: 20 additions & 0 deletions .github/workflows/markdownLink.yml
@@ -0,0 +1,20 @@
on:
pull_request:
branches:
- master
- 'release/**'
paths:
- '**.md'

name: Check links for modified files
jobs:
markdown-link-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: gaurav-nelson/github-action-markdown-link-check@v1
with:
use-quiet-mode: 'yes'
use-verbose-mode: 'yes'
check-modified-files-only: 'yes'
config-file: .github/workflows/markdown-link/config.json
14 changes: 0 additions & 14 deletions .vsts-ci/misc-analysis.yml
Expand Up @@ -90,20 +90,6 @@ jobs:
condition: succeededOrFailed()
workingDirectory: '$(repoPath)'
- ${{ if not(contains(variables['SYSTEM.COLLECTIONURI'],'mscodehub')) }}:
- pwsh: |
Import-module ./build.psm1
$path = Join-Path -Path $pwd -ChildPath './commonTestResults.xml'
$results = invoke-pester -Script ./test/common -OutputFile $path -OutputFormat NUnitXml -PassThru
Write-Host "##vso[results.publish type=NUnit;mergeResults=true;runTitle=Common Tests;publishRunAttachments=true;resultFiles=$path;]"
if($results.TotalCount -eq 0 -or $results.FailedCount -gt 0)
{
throw "Markdown tests failed"
}
displayName: Run Common Tests
condition: succeededOrFailed()
workingDirectory: '$(repoPath)'
- template: dailyBuildCompliance.yml@ComplianceRepo
parameters:
sourceScanPath: '$(repoPath)'
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -143,7 +143,7 @@ For more information on how and why we built this dashboard, check out this [blo

## Discussions

[GitHub Discussions](https://docs.github.com/en/free-pro-team@latest/discussions/quickstart) is a feature to enable fluid and open discussions within the community
[GitHub Discussions](https://docs.github.com/discussions/quickstart) is a feature to enable fluid and open discussions within the community
for topics that are not related to code, unlike issues.

This is an experiment we are trying in our repositories to see if it helps move discussions out of issues so that issues remain actionable by the team or members of the community.
Expand Down

0 comments on commit 7249200

Please sign in to comment.