Set Invoke-ScriptAnalyzer Path default value

[ThomasNieto]

PR Summary

Removes Path as a mandatory parameter and sets the default to the current working directory.

Resolves #1887

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Change is not breaking
• Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
• Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

[bergmeister]

Nice idea but you'd need to fix existing tests

[ThomasNieto]

I'm not sure why the tests are failing with change as the tests would be using a provided path and not a default.

[bergmeister]

I will try look into it another time and see whether I can do something about it, definitely before next release, sorry it's taken so long

[liamjpeters]

@ThomasNieto This seems like a good idea to me 🙂

@bergmeister, This fails many of the tests as the path now always has some value. If -ScriptDefinition is supplied - it's ignored

PSScriptAnalyzer/Engine/Commands/InvokeScriptAnalyzerCommand.cs

Line 433 in ab1dd25

if (!IsFileParameterSet())

PSScriptAnalyzer/Engine/Commands/InvokeScriptAnalyzerCommand.cs

Line 526 in ab1dd25

private bool IsFileParameterSet() => Path is not null;

You should probably make a change to the IsFileParameterSet() function to instead check that ScriptDefinition doesn't have some value. Or maybe better still return this.ParameterSetName.StartsWith("Path").

You will also need to update the markdown help file for Invoke-ScriptAnalyzer to tell the help system that path is no longer required:

PSScriptAnalyzer/docs/Cmdlets/Invoke-ScriptAnalyzer.md

Line 391 in a0365a5

Required: True

Or you'll get a test failure from Tests\Engine\ModuleHelp.Tests.ps1

PSScriptAnalyzer/Tests/Engine/ModuleHelp.Tests.ps1

Line 229 in a0365a5

$codeMandatory = $parameter.IsMandatory.toString()

Hope that helps 😀!