Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/update main model for automatic tap changer #598

Merged
merged 45 commits into from
May 24, 2024
Merged

feature/update main model for automatic tap changer #598

merged 45 commits into from
May 24, 2024

Conversation

Jerry-Jinfeng-Guo
Copy link
Contributor

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo commented May 15, 2024 •
edited

  • Update main_core/output → function skeletons are already in place (main_core.hpp and output.hpp).
  • User will need to be able to extract certain data (tap positions, etc.).
  • Attribute input should be checked (should have been in place)
  • attr output (optimizer >all the way back> output structure) needs to be done
  • add check to ensure that there can at most be one regulator for each transformer
  • include unit tests for the input/update/output functions of automatic tap changer.

@Jerry-Jinfeng-Guo
Added transformer regulator sanity check
157cf99 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo self-assigned this May 15, 2024
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the feature New feature or request label May 15, 2024
@Jerry-Jinfeng-Guo
const
412e43b 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
one couldn't be too const
497c78d 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
nor is format
a126c8a 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
Copy link
Contributor Author

At the moment the tap_position_optimizer still writes everything to a SolverOutput. The addition of MathOutput to include both SolverOutput and OptimizerOutput seems ignored. @mgovers Could the automatic tap changer adapt before I continue?

@mgovers
Copy link
Member

mgovers commented May 16, 2024

At the moment the tap_position_optimizer still writes everything to a SolverOutput. The addition of MathOutput to include both SolverOutput and OptimizerOutput seems ignored. @mgovers Could the automatic tap changer adapt before I continue?

Yes the optimizer needs to output a MathSolver that includes both the SolverOutput and the OptimizerOutput if that is waht you mean

Jerry-Jinfeng-Guo and others added 7 commits May 17, 2024 17:31
@Jerry-Jinfeng-Guo
getting transformer tap positions; msvc still complains
365ba60 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
format
bbd15f7 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
Merge branch 'main' into feature/update-main-model-for-tap-changer
4edc64e 
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
@Jerry-Jinfeng-Guo
the recursion as complained is impossible; werror suppressed
cbfada6 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
[skip ci] attempt fixing idx2d
a8990b2 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
gcc tamed
ff639dc 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
clang likes template in a specific way
74eee6e 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Jerry-Jinfeng-Guo and others added 11 commits May 21, 2024 12:35
@Jerry-Jinfeng-Guo
[skip ci] resolve comments
cee4275 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
Merge branch 'main' into feature/update-main-model-for-tap-changer
3799560 
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
@Jerry-Jinfeng-Guo
[skip ci] only for compilations, tweak mathoutput to include more
3550b7c 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
Merge branch 'main' into feature/update-main-model-for-tap-changer
f5b6e8e
@Jerry-Jinfeng-Guo
add typename
43b3e82 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
clean up a bit before tests
494942b 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
Merge branch 'main' into feature/update-main-model-for-tap-changer
acb2baf
@Jerry-Jinfeng-Guo
[skip ci] tests. to be debug
41bd26c 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
test in this pr passes. onto debug other 4
b76a18e 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
test debug
b3ed691 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
@Jerry-Jinfeng-Guo
[skip ci] first version out of draft
3e799bb 
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers and others added 5 commits May 23, 2024 13:51
@mgovers
Update power_grid_model_c/power_grid_model/include/power_grid_model/c…
199c040 
…alculation_parameters.hpp


Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Signed-off-by: Martijn Govers <martygovers@hotmail.com>
@mgovers
output tap pos before restoring state from cache
59fa970 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
sonar cloud
fca6acf 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
output transformer tap regulator
9294395 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
output tap position
8f6104c 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers mentioned this pull request May 23, 2024
Merged
@mgovers
pos is an ID???
8fd28fc 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove constexpr
34f59b3 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers mentioned this pull request May 23, 2024
Merged
mgovers and others added 7 commits May 23, 2024 17:35
@mgovers
fix clang
05e3d27 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
only output regulated tap positions
c224f12 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove deprecated test
6d448b0 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
check for optimal output of auto tap pos
39e4501 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
resolve comments
4fd52b6 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@Jerry-Jinfeng-Guo
Merge pull request #607 from PowerGridModel/feature/tap-regulator-out…
b83b87a 
…put-1

Feature/tap regulator output
@mgovers
add tests for main core tap regulator output
07e4c13 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers enabled auto-merge May 24, 2024 08:47
@mgovers
resolve comments
b3132d6 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
mgovers previously approved these changes May 24, 2024
View reviewed changes
@mgovers
fix gcc
591a56f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
mgovers previously approved these changes May 24, 2024
View reviewed changes
@mgovers
resolve sonar cloud
6a0d614 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mgovers mgovers added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit 1239c48 May 24, 2024
26 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/update-main-model-for-tap-changer branch May 24, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers approved these changes

@TonyXiang8787 TonyXiang8787 Awaiting requested review from TonyXiang8787

@petersalemink95 petersalemink95 Awaiting requested review from petersalemink95

Assignees

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jerry-Jinfeng-Guo @mgovers @TonyXiang8787 @petersalemink95