Feature/remove enable if

[mgovers]

modernize: remove std::enable_if in multiple places (cfr. #276 and made possible by #281 )

Resolves sonar cloud issues:

• https://sonarcloud.io/project/issues?open=AYjY5Aa3FAAkiiaHSIS6&id=PowerGridModel_power-grid-model (cfr. cpp:S6195 )
• https://sonarcloud.io/project/issues?resolved=false&sinceLeakPeriod=true&types=CODE_SMELL&branch=release%2Fshort-circuit-calculation&id=PowerGridModel_power-grid-model&open=AYjh5LYd09m1AxLltVij (cfr. cpp:S6009 )
• https://sonarcloud.io/project/issues?open=AYe820JVRLG_-2F7Nz6T&id=PowerGridModel_power-grid-model (cfr. cpp:S1709)
• https://sonarcloud.io/project/issues?open=AYe9198DcdHTx0no7scQ&id=PowerGridModel_power-grid-model (cfr. cpp:S6462)

[TonyXiang8787]

@mgovers please have a look at the build guide. To see if the required C++ standard and compiler version needs to be updated.

[mgovers]

@mgovers please have a look at the build guide. To see if the required C++ standard and compiler version needs to be updated.

According to the build guide:

Compiler Support

You need a C++ compiler with C++20 support. Below is a list of tested compilers:

Linux

• gcc >= 10.0
  • Version 10.0 tested using the version in the manylinux2014 container.
  • Version 11.x tested in CI
• Clang >= 14.0
  • Version 14.x tested in CI

You can define the environment variable CXX to for example clang++ to specify the C++ compiler.

Windows

• MSVC >= 17.5
  • Latest release tested in CI (e.g. Visual Studio 2022, IDE or build tools)
• Clang CL >= 14.0
  • Latest release tested in CI (e.g. Visual Studio 2022, IDE or build tools)

macOS

• Clang >= 14.0
  • Latest release tested in CI

According to https://en.cppreference.com/w/cpp/compiler_support/20 , GCC has full support for concepts starting with GCC 10 and onward, so in that sense we shouldn't have to update the docs. However, the build guide still refers to manylinux2014. I will bump that to manylinux_2_28 and also bump the GCC version to 11.2 (which is the version in the manylinux_2_28 container) and 12.2 tested using the custom musllinux build

[TonyXiang8787]

@mgovers

manylinux_2_28 has GCC 12.
https://github.com/pypa/manylinux

[mgovers]

@mgovers

manylinux_2_28 has GCC 12.
https://github.com/pypa/manylinux

oh sorry apparently i was looking at an older thread (pypa/manylinux#1282). will fix. should we also bump the gcc version in CI?

[TonyXiang8787]

@mgovers
manylinux_2_28 has GCC 12.
https://github.com/pypa/manylinux

oh sorry apparently i was looking at an older thread (pypa/manylinux#1282). will fix. should we also bump the gcc version in CI?

You mean in the documentation or in CI itself?

[mgovers]

@mgovers
manylinux_2_28 has GCC 12.
https://github.com/pypa/manylinux

oh sorry apparently i was looking at an older thread (pypa/manylinux#1282). will fix. should we also bump the gcc version in CI?

You mean in the documentation or in CI itself?

CI itself, i mean. i'm fine either way but want to double-check

[TonyXiang8787]

@mgovers
manylinux_2_28 has GCC 12.
https://github.com/pypa/manylinux

oh sorry apparently i was looking at an older thread (pypa/manylinux#1282). will fix. should we also bump the gcc version in CI?

You mean in the documentation or in CI itself?

CI itself, i mean. i'm fine either way but want to double-check

I think it is good to update the CI compiler version to the newest.

[TonyXiang8787]

There is a work around to counter a GCC 10 bug.

power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/auxiliary/meta_data_gen.hpp

Line 26 in 0a19677

// TODO, remove this separate definition for UpdateType after migrating to gcc-11

Since we upgrade to GCC 12, that work around can be removed.

[mgovers]

now that i think about it, we'd better bump CI compiler versions in a separate PR because it may cause other not-yet-seen issues and i would like to isolate changes

[TonyXiang8787]

now that i think about it, we'd better bump CI compiler versions in a separate PR because it may cause other not-yet-seen issues and i would like to isolate changes

Okay. After you add comment for rk2_tensor. I will approve it.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

100.0% Coverage
0.0% Duplication